Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft badge shows on just published carousel item #274

Closed
emteknetnz opened this issue Jun 8, 2020 · 4 comments
Closed

Draft badge shows on just published carousel item #274

emteknetnz opened this issue Jun 8, 2020 · 4 comments

Comments

@emteknetnz
Copy link
Member

2.x-dev - what will become 2.6.x-dev, tested as part of cwp regression testing

Logged in as a "Content Author"

Create a "Home Page" (extends BaseHomePage)

Add a Carousel Item

Upload a new image - it will show the draft badge

  • the draft badge remained if I published the carousel item (instead of the page), though the image did actually publish

  • publishing the page with a draft image on a draft carousel item did work as expected

@brynwhyman
Copy link

I'm pretty sure this is another example of: silverstripe/silverstripe-asset-admin#960

@dhensby
Copy link
Contributor

dhensby commented Jul 4, 2021

closing as duplicate

@dhensby dhensby closed this as completed Jul 4, 2021
@michalkleiner
Copy link
Contributor

Should CWP issues stay open until the underlying issues are resolved? It may seem like there are no issues with CWP because it's all within the underlying modules, but it might be painting a wrong picture of the state of things.

@brynwhyman
Copy link

I think this should remain closed with silverstripe/silverstripe-asset-admin#960 known as the issue, unless there is something specific to the code in this module that is related.

Issues are not consistently linked to a corresponding CWP issue so I don't think it would be an accurate way to get an idea of the state of things. This cwp/cwp module provides some functionality for the Silverstripe CMS and is not communicated to be a dedicated issue tracker for CWP sites built with Silverstripe CMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants