Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Category icon" drop-down field #46

Closed
sachajudd opened this issue Jun 1, 2018 · 6 comments
Closed

Remove "Category icon" drop-down field #46

sachajudd opened this issue Jun 1, 2018 · 6 comments

Comments

@sachajudd
Copy link
Contributor

In the "Home" page type, under the "Features" tab, the "Category icon" drop-down field does not work and should be removed as it is not required in the themes.

Note: This is only an issue in the Starter theme, not Watea.

CMS-
image

Output-
image

cc @clarkepaul

@robbieaverill
Copy link
Contributor

robbieaverill commented Jun 1, 2018

The time has gone to be able to do this in CWP 2.0 since it would break the public API. We can hide it though, if you'd like - even here though it might be used by CWP projects in their own themes.

@sachajudd
Copy link
Contributor Author

In that case, if we can hide it that would be great. It would be good to keep in mind when we can remove it completely.

@robbieaverill
Copy link
Contributor

Cool, I guess we'd need to make it configurable so that anyone who does want them can re-enable them with configuration

@brynwhyman
Copy link

Maybe a silly question, but what's the reasoning for removing this functionality as opposed to fixing it so the category icons do work?

@robbieaverill
Copy link
Contributor

@brynwhyman the icons in the list are old, we use FontAwesome icons since the starter and Wātea themes have been created. Due to the the fact that enums are not extensible we can't easily make the list dynamic, so we "removed" it instead.

@maxime-rainville
Copy link

Not worth doing.

@maxime-rainville maxime-rainville closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants