Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from react-dnd to dnd-kit #343

Open
emteknetnz opened this issue Nov 26, 2024 · 0 comments
Open

Switch from react-dnd to dnd-kit #343

emteknetnz opened this issue Nov 26, 2024 · 0 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Nov 26, 2024

Follow on from #335

We are using react-dnd 5 in admin, asset-admin and elemental. The latest version is 16.

In LinkField we implemented drag and drop using dnd-kit instead due to it being more maintained and not completely breaking silverstripe/silverstripe-linkfield#166

We should not attempt to upgrade react-dnd, and instead switch everything over to dnd-kit instead. From memory we talked about doing this at some point offline at the time we did the linkfield work

Notes

  • If we can't do this for 6.0, we will aim for a minor release but if there are massive breakages for projects, we need to discuss the effects and consider if releasing it in a minor is appropriate

Acceptance criteria

  • react-dnd and react-dnd-html5-backend are replaced with dnd-kit
  • react-dnd and react-dnd-html5-backend dependencies are removed

New cards raised:

PRs

Elemental

The rest

@emteknetnz emteknetnz added this to the Silverstripe CMS 6.0 milestone Nov 26, 2024
@GuySartorelli GuySartorelli self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants