Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JS deps - Redux #333

Closed
1 task done
emteknetnz opened this issue Nov 19, 2024 · 1 comment
Closed
1 task done

Upgrade JS deps - Redux #333

emteknetnz opened this issue Nov 19, 2024 · 1 comment

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Nov 19, 2024

Split from #308

Upgrade redux to ^5 and react-redux to ^9 in the following modules

  • silverstripe/admin
  • silverstripe/asset-admin
  • silverstripe/campaign-admin
  • silverstripe/cms
  • silverstripe/contentreview
  • silverstripe/frameworktest
  • silverstripe/linkfield
  • silverstripe/mfa
  • silverstripe/session-manager
  • silverstripe/versioned-admin
  • dnadesign/silverstripe-elemental

Upgrade redux-thunk to ^3 in the following modules

  • silverstripe/admin
  • silverstripe/asset-admin
  • silverstripe/campaign-admin
  • silverstripe/frameworktest
  • silverstripe/linkfield

Notes

  • If redux upgrade causes problems with redux-form, we can't upgrade it - try a few majors just in case
    • In that case open a card to re-investigate replacing redux-form for CMS 7

Acceptance criteria

  • redux, react-redux and redux-thunk are upgraded to their latest major versions

Kitchen-sink CI

^ test failures are existing - elemental - framework

PRs

@GuySartorelli
Copy link
Member

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants