Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JS deps - Bootstrap / reactstrap #332

Open
3 tasks done
emteknetnz opened this issue Nov 19, 2024 · 1 comment
Open
3 tasks done

Upgrade JS deps - Bootstrap / reactstrap #332

emteknetnz opened this issue Nov 19, 2024 · 1 comment

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Nov 19, 2024

Split from #308

Upgrade bootstrap to ^5 in the following modules:

  • silverstripe/admin
  • silverstripe/asset-admin
  • silverstripe/campaign-admin
  • silverstripe/cms
  • silverstripe/linkfield
  • silverstripe/login-forms
  • silverstripe/versioned-admin
  • dnadesign/silverstripe-elemental

Update reactstrap to ^9 in the following modules:

  • silverstripe/admin
  • silverstripe/asset-admin
  • silverstripe/campaign-admin
  • silverstripe/cms
  • silverstripe/elemental-bannerblock
  • silverstripe/linkfield
  • silverstripe/mfa
  • silverstripe/session-manager
  • silverstripe/versioned-admin
  • dnadesign/silverstripe-elemental
  • bringyourownideas/silverstripe-maintenance

Acceptance criteria

  • Bootstrap is upgraded to the latest major version
  • Reactstrap is upgraded to the latest major version
  • A reasonably thorough styling regression check is performed

PRs

Kitchen sink CI run
Compare against regular CI run for any failures

@emteknetnz emteknetnz added this to the Silverstripe CMS 6.0 milestone Nov 19, 2024
@GuySartorelli GuySartorelli self-assigned this Jan 9, 2025
This was referenced Jan 15, 2025
@GuySartorelli GuySartorelli removed their assignment Jan 23, 2025
@emteknetnz emteknetnz self-assigned this Jan 23, 2025
@emteknetnz
Copy link
Member Author

Tested locally using chrome, I could only find one real issue and that was after setting up a locale in fluent, the locale selector in the left hand side is a wee bit wrong :-)

Image

Otherwise the only differences were radio + checkboxes being a little different, though they look fine IMO so keep as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants