Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace LeftAndMain extensions with raw config wherever possible. #194

Closed
2 tasks done
GuySartorelli opened this issue Feb 12, 2024 · 0 comments
Closed
2 tasks done
Assignees
Milestone

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Feb 12, 2024

Some of our modules use an Extension class to add i18n js, normal js, and css to LeftAndMain. E.g. this extension in asset-admin.

In silverstripe/silverstripe-admin#1678 we introduced a new LeftAndMain.extra_requirements_i18n configuration property.

This means we can now add all javascript, css, and i18n js to LeftAndMain via configuration. We should not have entire extensions dedicated to that, it's too hamfisted.

Acceptance criteria

  • Identify instances where there are LeftAndMain extensions that could be replaced with yml
  • Replace the classes with yml

CMS 5 PRs

CMS 6 PRs

Important

Don't merge these until the CMS 5 PRs have been merged up and the PRs have been rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants