JS pull-requests

[github-actions]

This is an automatically created issue used to list automatically created javascript pull requests every 3 months.

It was created by the .github/workflows/js-prs-issue.yml workflow in the silverstripe/.github repository.

Triage instructions (Silverstripe Ltd CMS Squad)

1. Put on the following labels:
   • type/enhancement
   • impact/low
   • affects/v5
2. Move this issue to the "Ready" column on our internal zenhub board

Update JS pull-requests:

• List of update JS pull-requests
• Merge these PRs if there are no merge-conflicts
• If there are merge conflicts in some PRs, then manually run the "Update JS" github action in the affected module. The github action will automatically close the old PR and delete the old branch.- If the new PRs still have merge conflicts, then close those PRs and run the steps below in the "Manually creating update JS pull-requests" section below for those relevant modules

Manually creating update JS pull-requests:

1. Ensure you have the default branch checked out for the module you are updating e.g. 5
2. Ensure silverstripe/silverstripe-admin is installed in a sibling directory
3. In the silverstripe-admin directory, ensure the default branch is checked out e.g. 2
4. In the silverstripe-admin directory, run yarn install
5. In the directory of module you're updating JS for, run yarn upgrade
6. Run yarn build in the directory of module you're updating JS for
7. Git commit, push the changes and create a pull-request
8. List the pull-request(s) on this issue
9. Move this issue to the peer review column on the CMS Squad internal zenhub board

Dependabot pull-requests:

• List of dependabot pull-requests
• Most of these should be automatically closed if the "Update JS pull-requests" above are merged
• You can make a judgement call as to whether to merge any easy ones that are left

Not going to fix the following failures because they're unsupported and non-trivial

• DEP Update JS dependencies silverstripe-ckan-registry#297

PRs

• DEP Update JS dependencies silverstripe-comments#379
• DEP Update JS dependencies cwp-starter-theme#233
• MNT Remove update-js workflow silverstripe-ckan-registry#298

[emteknetnz]

@GuySartorelli re the ckan - would it make sense to remove the upgrade-js workflow from that module since it's unsupported?

[GuySartorelli]

Good idea. Done in silverstripe/silverstripe-ckan-registry#298