Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpunit validation failure on exclude #109

Closed
emteknetnz opened this issue Sep 6, 2023 · 1 comment
Closed

phpunit validation failure on exclude #109

emteknetnz opened this issue Sep 6, 2023 · 1 comment
Assignees
@GuySartorelli
Labels
impact/low type/bug

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Sep 6, 2023 •
edited
Loading

When running phpunit tests on installer, getting the following validation error

  • Element 'exclude': Element content is not allowed, because the type definition is simple.

image

https://github.com/silverstripe/silverstripe-installer/blob/5/phpunit.xml.dist#L32

Looks like exclude is only for code-coverage reports https://docs.phpunit.de/en/9.6/configuration.html#the-exclude-element

Was introduced here
silverstripe/silverstripe-installer#356
and here
silverstripe/recipe-kitchen-sink#45

PRs
@emteknetnz emteknetnz self-assigned this Sep 7, 2023
This was referenced Sep 7, 2023
Merged
Merged
@emteknetnz emteknetnz removed their assignment Sep 7, 2023
@GuySartorelli GuySartorelli self-assigned this Sep 7, 2023
@GuySartorelli
Copy link
Member

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
impact/low type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli