Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android WebView: Cannot convert a Symbol value to a string #53

Open
Frenzie opened this issue Jan 26, 2024 · 0 comments
Open

Android WebView: Cannot convert a Symbol value to a string #53

Frenzie opened this issue Jan 26, 2024 · 0 comments

Comments

@Frenzie
Copy link

Frenzie commented Jan 26, 2024

Same issue as zloirock/core-js#1292, babel/babel#16219.

It seems to exclusively occur in Android WebView, even though theoretically that should be nearly identical to the latest version of Chrome. (Currently I have 1.20.x vs Chrome at 1.21.x, but it makes no difference in regular Android Chrome.)

Should be fixed by babel/babel#16225, available in v7.23.9

Something along these lines suffices to run grunt build, but the end result doesn't appear to be completely correct for Video.js purposes. Hopefully it's a quick fix for someone who knows what they're doing. ;-)

@babel/core": "7.23.9", is for the bug fix, "grunt-contrib-uglify": "5.2.1", is because older than v2 doesn't support keywords like const, which apparently doesn't play together with the newer babel/core.

diff --git a/package.json b/package.json
index ae16f82..1bc4728 100644
--- a/package.json
+++ b/package.json
@@ -35,7 +35,7 @@
   },
   "homepage": "https://github.com/silvermine/videojs-airplay#readme",
   "devDependencies": {
-    "@babel/core": "7.21.0",
+    "@babel/core": "7.23.9",
     "@babel/preset-env": "7.20.2",
     "@silvermine/eslint-config": "3.0.1",
     "@silvermine/standardization": "2.2.1",
@@ -43,7 +43,7 @@
     "babel-eslint": "10.1.0",
     "babelify": "10.0.0",
     "check-node-version": "4.0.2",
-    "core-js": "3.28.0",
+    "core-js": "3.35.1",
     "coveralls": "3.0.2",
     "eslint": "6.8.0",
     "expect.js": "0.3.1",
@@ -51,7 +51,7 @@
     "grunt-browserify": "5.3.0",
     "grunt-contrib-clean": "1.1.0",
     "grunt-contrib-copy": "1.0.0",
-    "grunt-contrib-uglify": "3.0.1",
+    "grunt-contrib-uglify": "5.2.1",
     "grunt-contrib-watch": "1.1.0",
     "grunt-postcss": "0.9.0",
     "grunt-sass": "3.1.0",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant