underscore.js dependency for a single extend call is overkill

[dominikg]

This is a runtime dependency and has to be downloaded, extracted, parsed by every enduser.

Please replace the extend call with Object.assign or some other plain method and drop the dependency.

[dominikg]

see

videojs-airplay/src/js/enableAirPlay.js

Line 96 in 305c613

var pluginOptions = _.extend({ addButtonToControlBar: true }, options || {});

[jthomerson]

Good point. Underscore is just a standard library we use a lot of places, but you're right we only have the one call in this codebase. Pull requests welcome. Make sure to familiarize yourself with our coding standards in order to ensure your PR success.

[yokuze]

Please also note that our plugins support IE 11, so whatever solution is chosen must be compatible with IE 11, which Object.assign is not.

[dominikg]

the most simple solution would be like this:

var pluginOptions =  options || {};
if(pluginOptions.addButtonToControlBar == null ) {
  pluginOptions.addButtonToControlBr = true;
}

this changes the behavior slighly (mutation of passed options if addButtonToControlBar isn't defined)

[jthomerson]

Fixed by #34