Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language support #40

Closed
bobh0303 opened this issue Oct 3, 2021 · 6 comments
Closed

language support #40

bobh0303 opened this issue Oct 3, 2021 · 6 comments

Comments

@bobh0303
Copy link
Contributor

bobh0303 commented Oct 3, 2021

At present KHN (which is used in the OT code) is not a registered OT tag; I'm assuming it is supposed to be used for bcp47 khn (which is used in the Graphite code).

According to the Ethnologue, khn is Khandesi, a language of India, and written with Devanagari script. Do some Khandesi write with Myanmar script? If so, we'll want to register KHN -- but there are some oddities in the font code that make me wonder.

According to the table(language) in myfeatures.gdl, language tags khn and kht both turn on the Khamti language processing:

khamti {
    languages = ("khn", "kht");
    khamti = 1;
    filled = 1;
};

The OpenType code also mentions both of these, but with different functionality in padauk.fea:

feature locl {
 script mym2;
     language KHN  exclude_dflt;
      lookup mym2_locl_dot;
     language KHT  exclude_dflt;
      lookup mym2_locl_dot;
      lookup mym2_locl_khamti;
    ...

(In a similar issue, the table(language) includes both aio and phk:

aiph {
    languages = ("aio", "phk");
    khamti = 1;
    aitonph = 1;
    filled = 1;
};

but the equivalent OT tags AIO and PHK do not appear in the OT code.)

Related:

README.txt mentions

Features:
* Special support for: ksw, kht, kyu, shn, aio, phk, csh
* Variation Selector support for kht, aio, phk

while README.md mentions:

## Features
* Special support for: ksw, kht, kyu, shn, aio, phk
* Variation Selector support for kht, aio, phk

Note that

  • neither mentions khn
  • one (but not both) mention csh
@bobh0303
Copy link
Contributor Author

bobh0303 commented Oct 6, 2021

According to the Ethnologue, khn is Khandesi, a language of India, and written with Devanagari script. Do some Khandesi write with Myanmar script? If so, we'll want to register KHN -- but there are some oddities in the font code that make me wonder.

@jcoblentz or @mhosken could you clarify whether khn is actually correct for padauk?

@bobh0303
Copy link
Contributor Author

Also, ISO csh is already in the the OT spec under QIN -- is a reason that isn't being used?

@jcoblentz
Copy link
Contributor

QIN is on the list of things to change. See #39

@mhosken
Copy link
Contributor

mhosken commented Jun 1, 2022

Harfbuzz maps the lang code khn to the internal language tag of KHN to conform to Microsoft's mapping. It also maps to KHT internally too. So I guess it just picks one of the two. This implies that KHN is Microsoft's internal langtag for the kht language.

@bobh0303
Copy link
Contributor Author

bobh0303 commented Jun 1, 2022

Harfbuzz maps the lang code khn to the internal language tag of KHN to conform to Microsoft's mapping
...
This implies that KHN is Microsoft's internal langtag for the kht language.

You often manage leaps of logic that my feeble brain can't follow so I may be wrong, but I don't understand how these statements can be the case since Microsoft language tag registry contains neither KHN nor khn.

@devosb
Copy link
Contributor

devosb commented Nov 8, 2024

The unregistered OpenType language codes of CSH and KHN that are in the font were needed for compatibility with older versions of HarfBuzz and/or DirectWrite. They will stay in the font for the 5.100 release, but be removed for the 6.000 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants