Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AG queries with counterexamples is doubly-inverted, which is confusing. #41

Open
sillydan1 opened this issue Dec 22, 2022 · 0 comments
Open
Labels
bug 🐛 Something isn't working

Comments

@sillydan1
Copy link
Owner

sillydan1 commented Dec 22, 2022

With AG queries, they are always "true" until you find a counter-example, then they are "false", but with a solution. Right now, we are doing the opposite.

In other words: AG queries (safety queries) should be disproven by finding a trace, not proven.

Solutions should be refactored to have:

struct query_answer_t {
  query_t q;
  std::optional<state_it_t> witnessing_state; // backtraceable - if optional is empty, no trace is availble (yet)
  bool witnessing_state_is_proof_of_unsat; // when true, then the query is _not_ satisfied
}

or something like that.

See forward_reachability_searcher.cpp:84

@sillydan1 sillydan1 added bug 🐛 Something isn't working good first issue 🧑‍💻 Good for newcomers labels Dec 22, 2022
@sillydan1 sillydan1 removed the good first issue 🧑‍💻 Good for newcomers label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant