Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GHA layer caching when building docker images #1652

Open
megahirt opened this issue Dec 15, 2022 · 2 comments
Open

use GHA layer caching when building docker images #1652

megahirt opened this issue Dec 15, 2022 · 2 comments
Labels
engineering Tasks which do not directly relate to a user-facing feature or fix

Comments

@megahirt
Copy link
Collaborator

See https://github.com/docker/build-push-action for documentation

Our CI docker build process has to build our images from scratch every time because there is no layer caching available. Utilizing caching should speed up our image build considerably.

@alex-larkin alex-larkin added the engineering Tasks which do not directly relate to a user-facing feature or fix label Apr 27, 2023
@rmunn
Copy link
Collaborator

rmunn commented May 24, 2024

We currently aren't using the build-push-action, relying instead on docker compose build to build the entire dependency tree for us. I estimated this task as Tiny at first, but now that I realize that it would involve a larger rewrite of the GHA workflow, I'm bumping the estimate to Small as it will require quite a bit of testing to make sure we got the details right.

@hahn-kev
Copy link
Collaborator

hahn-kev commented May 24, 2024

Looks like we can do something like this to solve our problem
https://stackoverflow.com/a/75544124/1620542

then for the cache to and from we can probably use some of the patterns defined here
https://docs.docker.com/build/ci/github-actions/cache/

this means we don't need to rewrite our build workflow or anything like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Tasks which do not directly relate to a user-facing feature or fix
Projects
Development

No branches or pull requests

4 participants