Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for translate.py to error when requested model checkpoint is unavailable #593

Open
bhartmoore opened this issue Nov 14, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@bhartmoore
Copy link
Collaborator

With the update to remove OpenNMT, silnlp no longer throws an error if the requested fine-tuned model checkpoint is unavailable. Instead, it outputs a well-formatted inference from the base model, which will contain garbage in most cases because the target language is not available in the base model. Because we now clean up models after just 30 days, this situation may arise more frequently. It would be helpful if translate.py could throw an error or warning when the requested model checkpoint is not found. Even having the ClearML job fail would be preferable to having it complete from the base model for an unknown language.

@bhartmoore bhartmoore added the enhancement New feature or request label Nov 14, 2024
@ddaspit ddaspit moved this from 🆕 New to 🔖 Ready in SIL-NLP Research Nov 14, 2024
@isaac091
Copy link
Collaborator

It does already throw a warning, WARNING - Model has no checkpoints. Using base model.. However, it's easy to miss as just one line of text, so I think it would make sense to have it fail completely.

Sometimes for development tasks it's nice to be able to run the script without needing a trained model, but we could add a "base" or "0" checkpoint option for that.

@bhartmoore
Copy link
Collaborator Author

Thanks, Isaac! Looking back, I see that warning in the log from drafts I ran that hit this issue. I'm open to whatever solution makes sense for both development and user support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants