-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API example program #539
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
=======================================
Coverage 57.25% 57.25%
=======================================
Files 299 299
Lines 15664 15664
Branches 2163 2163
=======================================
Hits 8968 8968
Misses 6054 6054
Partials 642 642 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pmachapman)
samples/ApiExample/data/TEA.zip
line 0 at r1 (raw file):
I would prefer not to check in binary files. Could you check in the project files directly, and then add code to zip up the files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 27 files reviewed, 1 unresolved discussion (waiting on @ddaspit)
samples/ApiExample/data/TEA.zip
line at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
I would prefer not to check in binary files. Could you check in the project files directly, and then add code to zip up the files?
Done.
36d31f8
to
cb00855
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent contribution. Thank you.
Reviewed 23 of 23 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)
This PR adds an API example program to the samples directory showing how to create a translation engine, and generate a pre-translation.
Please let me know if you want any further work done to it, or any further documentation.
The USFM files in the two directories are entirely my own work (i.e. no copyright issues).
This change is