Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel Corpora Documentation #507

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Oct 10, 2024

Most documentation was already present, but there were still a few missing pieces/errors. Let me know if anything else seems to be missing. I'm sure there will still be clarification needed in some cases, and we can clarify in the documentation as SF has questions.


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from johnml1135 October 10, 2024 14:01
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.62%. Comparing base (93ca485) to head (a949daa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   56.62%   56.62%           
=======================================
  Files         299      299           
  Lines       15592    15592           
  Branches     2149     2149           
=======================================
  Hits         8829     8829           
  Misses       6109     6109           
  Partials      654      654           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@johnml1135 johnml1135 merged commit 7b79fbc into main Oct 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants