Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #294 - Nswag 8618 warning by upgrading Nswag #472

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Aug 29, 2024

This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit August 29, 2024 21:28
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.77778% with 26 lines in your changes missing coverage. Please review.

Project coverage is 56.58%. Comparing base (a111c67) to head (bbf5978).

Files with missing lines Patch % Lines
src/Serval/src/Serval.Client/Client.g.cs 77.77% 23 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
- Coverage   56.63%   56.58%   -0.05%     
==========================================
  Files         275      275              
  Lines       14174    14174              
  Branches     1902     1908       +6     
==========================================
- Hits         8028     8021       -7     
- Misses       5557     5563       +6     
- Partials      589      590       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit bb36491 into main Sep 3, 2024
3 checks passed
@johnml1135 johnml1135 deleted the nswag_upgrade branch September 3, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants