Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Echo issues #444

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Fix Echo issues #444

merged 1 commit into from
Jul 29, 2024

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Jul 29, 2024 •
edited by ddaspit
Loading

Fixes #404
Addresses part of #396

  • Make IsNative always true for echo
  • Throw invalid operation exception on invalid argument rpc exception when src and trg language are not the same for echo engine (tldr, used to give 500 code for Echo with en, es lang codes; now 400 code)

This change is Reviewable

@Enkidu93
Make IsNative always true for echo; rethrow on invalid argument rpc e…
8e57256 
…xception when src and trg language are not the same for echo
@Enkidu93 Enkidu93 requested review from ddaspit and johnml1135 July 29, 2024 16:22
ddaspit
ddaspit approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit b7b8b68 into main Jul 29, 2024
2 checks passed
@johnml1135 johnml1135 deleted the echo_language_code_issues branch July 29, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddaspit ddaspit ddaspit approved these changes

@johnml1135 johnml1135 Awaiting requested review from johnml1135

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Echo engine gives 500 code when specifying distinct source and target language codes for new engine
3 participants
@Enkidu93 @ddaspit @johnml1135