Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Already written text is not being pre-translation on Serval QA #536

Closed
pmachapman opened this issue Nov 4, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@pmachapman
Copy link
Collaborator

pmachapman commented Nov 4, 2024

On Serval QA, any text that has already been entered by the user is not being pre-translated. This is a regression of #370.

Compare this pre-translation on Serval Prod:
Image

To Serval QA:
Image

Both builds had the same source and target, and were both set to train on MRK and pre-translate JHN. The translations were generated with only 20 max_steps.

Pre-translation of already written text is an important feature of Serval (and was originally requested by users), so I would classify this as a blocker for QA going to production.

@johnml1135
Copy link
Collaborator

This is related to #533 - We can discuss at the meeting exactly how to handle this.

@johnml1135 johnml1135 added this to Serval Dec 4, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Serval Dec 4, 2024
@johnml1135 johnml1135 moved this from 🆕 New to 👀 In review in Serval Dec 4, 2024
@johnml1135 johnml1135 self-assigned this Dec 4, 2024
@johnml1135
Copy link
Collaborator

johnml1135 commented Dec 9, 2024

@pmachapman - is this now resolved on QA?

@pmachapman
Copy link
Collaborator Author

@johnml1135 Yes, it is. Thanks!

Image

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Serval Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants