Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If one corpora is specified in a build, it should be assumed that all others are not used #516

Closed
johnml1135 opened this issue Oct 17, 2024 · 1 comment · Fixed by #520
Closed

If one corpora is specified in a build, it should be assumed that all others are not used #516

johnml1135 opened this issue Oct 17, 2024 · 1 comment · Fixed by #520
Assignees
@johnml1135 @Enkidu93

Comments

@johnml1135
Copy link
Collaborator

johnml1135 commented Oct 17, 2024 •
edited
Loading

Is this true? Is there a test for this? This is a spin-off of #514.
@johnml1135 johnml1135 self-assigned this Oct 17, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Serval Oct 17, 2024
@johnml1135 johnml1135 mentioned this issue Oct 17, 2024
Closed
@johnml1135 johnml1135 mentioned this issue Oct 25, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Serval Oct 25, 2024
johnml1135 added a commit that referenced this issue Oct 28, 2024
@johnml1135
A better fix for #516.
b270eb5
@johnml1135 johnml1135 reopened this Oct 28, 2024
@johnml1135
Copy link
Collaborator Author

This should be applied independently for pretranslate and trainOn.

@johnml1135 johnml1135 mentioned this issue Oct 28, 2024
Merged
johnml1135 added a commit that referenced this issue Oct 29, 2024
@johnml1135
A better fix for #516. (#521)
f7060c7 
* A better fix for #516.

* Update documentation

* reviewer comment

* Documentation clarification

* Updated parameter names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnml1135 johnml1135

@Enkidu93 Enkidu93

Labels
None yet
Projects
Serval
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pretranslation filtering sillsdev/serval
2 participants
@johnml1135 @Enkidu93