Convert LeftMargin, RightMargin, and FirstLineIndent to floats

[ddaspit]

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.96%. Comparing base (cc7c4ea) to head (f7fd79c).

Files with missing lines	Patch %	Lines
src/SIL.Machine/Corpora/UsfmStylesheet.cs	85.71%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   69.96%   69.96%           
=======================================
  Files         379      379           
  Lines       31781    31778    -3     
  Branches     4456     4456           
=======================================
- Hits        22236    22235    -1     
+ Misses       8511     8509    -2     
  Partials     1034     1034           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[johnml1135]

src/SIL.Machine/Corpora/UsfmStylesheet.cs line 423 at r1 (raw file):

                )
            )
            {

Why is the * 1000 removed? FirstLineIndent changes behavior - is this intended?

[johnml1135]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)

[ddaspit]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)

---

src/SIL.Machine/Corpora/UsfmStylesheet.cs line 423 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Why is the * 1000 removed? FirstLineIndent changes behavior - is this intended?

Scaling the float values by 1000 is what Paratext does and we were just emulating the behavior. I did a bit more investigation into why Paratext does this. It is because of a weird issue that is specific to Paratext.

[johnml1135]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)