Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.4.0 #258

Merged
merged 1 commit into from
Oct 15, 2024
Merged

v3.4.0 #258

merged 1 commit into from
Oct 15, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Oct 15, 2024

This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit October 15, 2024 18:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.95%. Comparing base (204bb50) to head (972e060).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   69.95%   69.95%           
=======================================
  Files         379      379           
  Lines       31767    31767           
  Branches     4454     4454           
=======================================
  Hits        22223    22223           
  Misses       8510     8510           
  Partials     1034     1034           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit a8a20ba into master Oct 15, 2024
4 checks passed
@johnml1135 johnml1135 deleted the v3.4.0 branch October 15, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants