Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter for filtering key terms by book/chapters #256

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Oct 11, 2024

Addresses sillsdev/serval#476

Supports sillsdev/serval#508


This change is Reviewable

@johnml1135
Copy link
Collaborator

src/SIL.Machine/Corpora/ParatextProjectTermsParserBase.cs line 200 at r1 (raw file):

                    && verseRefs.Any(vr =>
                        chapters.TryGetValue(vr.Book, out HashSet<int> bookChapters)
                        && (bookChapters.Count() == 0 || bookChapters.Contains(vr.ChapterNum))

Where are the tests for this?

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 force-pushed the filter_key_terms_by_chapter branch from f064407 to ff75f8d Compare October 11, 2024 20:34
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.90%. Comparing base (3616630) to head (ff75f8d).

Files with missing lines Patch % Lines
....Machine/Corpora/ParatextProjectTermsParserBase.cs 87.50% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   69.88%   69.90%   +0.01%     
==========================================
  Files         379      379              
  Lines       31732    31765      +33     
  Branches     4450     4453       +3     
==========================================
+ Hits        22175    22204      +29     
- Misses       8525     8527       +2     
- Partials     1032     1034       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 83a06ee into master Oct 11, 2024
4 checks passed
@johnml1135 johnml1135 deleted the filter_key_terms_by_chapter branch October 11, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants