-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip parsing excluded books when preprocessing #207
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 67.35% 67.23% -0.13%
==========================================
Files 441 441
Lines 35144 35277 +133
Branches 4703 4721 +18
==========================================
+ Hits 23672 23717 +45
- Misses 10381 10466 +85
- Partials 1091 1094 +3 ☔ View full report in Codecov by Sentry. |
TrainOnChapters is never null (a bug I found). Either we check for null or length == 0, or we change how it is made up at the Serval level to send a true null down. |
is null or empty. |
null or empty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ddaspit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ddaspit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)
Incorporate accidentally removed logic from sillsdev/machine#207 (#467)
This change is