Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message to include filename #90

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

isaac091
Copy link
Collaborator

@isaac091 isaac091 commented Dec 21, 2023

This change is Reviewable

@isaac091 isaac091 requested a review from ddaspit December 21, 2023 21:14
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a359d10) 86.82% compared to head (4cbf314) 86.82%.
Report is 5 commits behind head on main.

Files Patch % Lines
machine/corpora/usfm_file_text.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   86.82%   86.82%           
=======================================
  Files         226      226           
  Lines       13629    13629           
=======================================
  Hits        11833    11833           
  Misses       1796     1796           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator

machine/corpora/usfm_file_text.py line 39 at r1 (raw file):

                    id = id[:index]
                return id.strip().upper()
    raise RuntimeError("The USFM file '{filename}' does not contain an 'id' marker.")

Doesn't that need to be an f-string? Does it render correctly?

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit and @isaac091)

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 8a9b64e into main Jan 2, 2024
14 checks passed
@isaac091 isaac091 deleted the update_id_error branch January 2, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When an SFM file fails to parse report the full file path and if possible the line number.
3 participants