Update learning rate for #116 and other small error

[johnml1135]

#116

---

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.96%. Comparing base (368120f) to head (af0194c).

Files with missing lines	Patch %	Lines
machine/jobs/nmt_engine_build_job.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   87.96%   87.96%           
=======================================
  Files         262      262           
  Lines       15500    15500           
=======================================
  Hits        13634    13634           
  Misses       1866     1866           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ddaspit]

I don't think we are ready to make this change yet. We need to come up with a plan for how we are going to roll this out first.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @johnml1135)

---

machine/jobs/nmt_engine_build_job.py line 77 at r1 (raw file):

            model_trainer.train(progress=phase_progress, check_canceled=check_canceled)
            model_trainer.save()
            train_corpus_size = parallel_corpus.count()

Why was this change necessary?

[johnml1135]

machine/jobs/nmt_engine_build_job.py line 77 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Why was this change necessary?

I made a change for the word alignment - and made it incorrectly. This is to fix the code. I can make a separate PR for this if we are not ready for the learning rate changes.

[ddaspit]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @johnml1135)

---

machine/jobs/nmt_engine_build_job.py line 77 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

I made a change for the word alignment - and made it incorrectly. This is to fix the code. I can make a separate PR for this if we are not ready for the learning rate changes.

Yes, go ahead and make a separate PR for now.

[johnml1135]

machine/jobs/nmt_engine_build_job.py line 77 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Yes, go ahead and make a separate PR for now.

Done.

[johnml1135]

@ddaspit - I believe we are finally ready to make this change.

[ddaspit]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)

---

machine/jobs/nmt_engine_build_job.py line 77 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Done.

If the model_trainer.stats.train_corpus_size is not returning the correct value, it should be fixed in the trainer class.

[johnml1135]

machine/jobs/nmt_engine_build_job.py line 77 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

If the model_trainer.stats.train_corpus_size is not returning the correct value, it should be fixed in the trainer class.

I believe the issue may have been resolved elsewhere. Let's move it out of this PR.

[ddaspit]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)