[ReviewEntries] Turn off return-to-first-page-when-row-is-edited #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3158 +/- ##
==========================================
- Coverage 75.02% 74.98% -0.04%
==========================================
Files 271 271
Lines 10394 10394
Branches 1230 1230
==========================================
- Hits 7798 7794 -4
- Misses 2237 2240 +3
- Partials 359 360 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Opened discussion about separating functionality for editing and for filtering/sorting: KevinVandy/material-react-table#1157 |
jasonleenaylor
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3147
Disable
autoResetPageIndex(https://www.material-react-table.com/docs/guides/pagination#customize-pagination-behavior), which resets the table to the first page when editing/filtering/sorting. (It would be nice to have the latter two, but not at the expense of the first one.)This change is