Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NUC Instructions for Use #3123

Merged
merged 2 commits into from
May 29, 2024
Merged

Update NUC Instructions for Use #3123

merged 2 commits into from
May 29, 2024

Conversation

jmgrady
Copy link
Collaborator

@jmgrady jmgrady commented May 29, 2024

Update the NUC Instructions for Use to:

  • change the start up wait time from 30 seconds to a couple minutes; the WiFi access point is up in 30 seconds but it can take a couple minutes before all of the Kubernetes resources are available
  • update the image to use the newer NUC since that is the one that is more likely to be loaned to teams.

This change is Reviewable

@jmgrady jmgrady added the documentation Improvements or additions to documentation label May 29, 2024
@jmgrady jmgrady requested a review from jasonleenaylor May 29, 2024 14:54
@jmgrady jmgrady self-assigned this May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.99%. Comparing base (2d265ce) to head (e331288).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3123   +/-   ##
=======================================
  Coverage   74.99%   74.99%           
=======================================
  Files         271      271           
  Lines       10415    10415           
  Branches     1235     1235           
=======================================
  Hits         7811     7811           
  Misses       2242     2242           
  Partials      362      362           
Flag Coverage Δ
backend 83.95% <ø> (ø)
frontend 66.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmgrady jmgrady requested review from andracc and removed request for jasonleenaylor May 29, 2024 15:27
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@jmgrady jmgrady merged commit 355efb0 into master May 29, 2024
18 checks passed
@jmgrady jmgrady deleted the update-ifu branch May 29, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants