Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Replace .ContainsKey with .TryGetValue/.TryAdd #3052

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 10, 2024

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1854
In preparation for updated pragma suggestions with .NET 8.0 in #3046.


This change is Reviewable

@imnasnainaec imnasnainaec added backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue labels Apr 10, 2024
@imnasnainaec imnasnainaec self-assigned this Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes missing coverage. Please review.

Project coverage is 75.02%. Comparing base (c6f2191) to head (119e4ff).

Files Patch % Lines
Backend/Services/StatisticsService.cs 25.00% 10 Missing and 2 partials ⚠️
Backend/Services/LiftService.cs 60.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3052      +/-   ##
==========================================
+ Coverage   74.99%   75.02%   +0.02%     
==========================================
  Files         271      271              
  Lines       10415    10394      -21     
  Branches     1235     1230       -5     
==========================================
- Hits         7811     7798      -13     
+ Misses       2242     2237       -5     
+ Partials      362      359       -3     
Flag Coverage Δ
backend 84.04% <44.82%> (+0.09%) ⬆️
frontend 66.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 5 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 6302b3c into master Jun 5, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the trygetvalue branch June 5, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants