Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message for longer key requirement #3013

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Update error message for longer key requirement #3013

merged 2 commits into from
Mar 25, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Mar 22, 2024

Follow-up to #2160


This change is Reviewable

@imnasnainaec imnasnainaec requested a review from jmgrady March 22, 2024 15:19
@imnasnainaec imnasnainaec self-assigned this Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.75%. Comparing base (e79ca3a) to head (81cd701).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3013      +/-   ##
==========================================
- Coverage   72.76%   72.75%   -0.01%     
==========================================
  Files         264      264              
  Lines       10201    10201              
  Branches     1196     1196              
==========================================
- Hits         7423     7422       -1     
  Misses       2429     2429              
- Partials      349      350       +1     
Flag Coverage Δ
backend 82.78% <ø> (-0.03%) ⬇️
frontend 63.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)


Backend/Startup.cs line 109 at r1 (raw file):

            // The JWT key size must be at least 256 bits long.
            const int minKeyLength = 256 / 8;

Is there a way to query the library instead of hard-coding this?

Code quote:

256

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


Backend/Startup.cs line 109 at r1 (raw file):

Previously, jmgrady (Jim Grady) wrote…

Is there a way to query the library instead of hard-coding this?

Good thought! I've looked and haven't found any way to. (I'm also still inclined to entirely remove this environment variable requirement and autogenerate it.)

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@jmgrady jmgrady merged commit 1d0ca5c into master Mar 25, 2024
17 checks passed
@jmgrady jmgrady deleted the 32 branch March 25, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants