Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import order by moving 'type' #2894

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix import order by moving 'type' #2894

merged 1 commit into from
Jan 24, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 23, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue labels Jan 23, 2024
@imnasnainaec imnasnainaec self-assigned this Jan 23, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fff32e9) 72.83% compared to head (df9abb6) 63.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2894      +/-   ##
==========================================
- Coverage   72.83%   63.29%   -9.55%     
==========================================
  Files         264      218      -46     
  Lines       10016     5195    -4821     
  Branches     1183      607     -576     
==========================================
- Hits         7295     3288    -4007     
+ Misses       2378     1703     -675     
+ Partials      343      204     -139     
Flag Coverage Δ
backend ?
frontend 63.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec requested a review from jmgrady January 24, 2024 14:09
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 92ac295 into master Jan 24, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the import-type branch January 24, 2024 16:01
jmgrady pushed a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants