-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LangingPage] Add paragraph with call-to-action, sign-up button #1616
Conversation
src/components/LandingPage/index.tsx, line 87 at r1 (raw file):
Add return type annotation? |
src/components/LandingPage/index.tsx, line 87 at r1 (raw file): Previously, johnthagen wrote…
(Applies to all functions in this file) |
src/resources/translations.json, line 43 at r1 (raw file):
I would add a line break before Should the button also be on its on line and centered? |
src/resources/translations.json, line 43 at r1 (raw file): Previously, johnthagen wrote…
Also, maybe want to make the final sentence more imperative? "Get started with The Combine by signing up" ? |
Codecov Report
@@ Coverage Diff @@
## master #1616 +/- ##
==========================================
- Coverage 52.33% 52.33% -0.01%
==========================================
Files 272 272
Lines 8336 8337 +1
Branches 607 607
==========================================
Hits 4363 4363
- Misses 3486 3487 +1
Partials 487 487
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor and @johnthagen)
src/resources/translations.json, line 43 at r1 (raw file):
Previously, johnthagen wrote…
Also, maybe want to make the final sentence more imperative?
"Get started with The Combine by signing up" ?
Done.
This pull request introduces 2 alerts when merging 151d784 into 555605e - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, 2 of 4 files at r2, 7 of 7 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jasonleenaylor)
Resolves #1604, step 2.
This change is