Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate all button styles to ensure consistency #1618

Open
johnthagen opened this issue Mar 18, 2022 · 1 comment
Open

Evaluate all button styles to ensure consistency #1618

johnthagen opened this issue Mar 18, 2022 · 1 comment
Labels

Comments

@johnthagen
Copy link
Collaborator

johnthagen commented Mar 18, 2022

The following button styles are part of the The Combine

Grey Fill, Black Text

Screenshot 2022-03-18 141611

Screenshot 2022-03-18 142037

Screenshot 2022-03-18 142318

Screenshot 2022-03-18 142544

Screenshot 2022-03-18 142738

Screenshot 2022-03-18 143122

Blue Fill, White Text

Screenshot 2022-03-18 142007

Screenshot 2022-03-18 142251

Screenshot 2022-03-18 142332

Screenshot 2022-03-18 142901

Screenshot 2022-03-18 142959

Screenshot 2022-03-18 143524

Blue Outline, Blue Text

Screenshot 2022-03-18 142932

Screenshot 2022-03-18 143305

Screenshot 2022-03-18 143504

Screenshot 2022-03-18 143602

Screenshot 2022-03-18 143713

No Fill, Black Text

Screenshot 2022-03-18 141744

Screenshot 2022-03-18 143815

No Fill, Blue Text

Screenshot 2022-03-18 143149

Grey Fill, Red Text

Screenshot 2022-03-18 142701

@jasonleenaylor
Copy link
Contributor

We want to make sure that our supported button styles are coming from the material theme.
Anything other than the following three styles should be considered unusual and probably changed.

  1. Blue background button, Primary style (buttons we think you want to click)
  2. Gray background button, Secondary style (buttons that are available, but not the primary action)
  3. Red text button, Should be a custom style (buttons that you should press with caution, delete, archive, ect.)

When looking at this issue also consider moving custom styling in our re-usable button components into the theme.

@imnasnainaec imnasnainaec added Size: M Medium sized issue and removed Size: S Small sized issue labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants