Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset proxyConfiguration after deployment #236

Closed
ghost opened this issue Jun 16, 2021 · 4 comments · Fixed by #293
Closed

reset proxyConfiguration after deployment #236

ghost opened this issue Jun 16, 2021 · 4 comments · Fixed by #293

Comments

@ghost
Copy link

ghost commented Jun 16, 2021

heyja,

We are using this script and noticed, that the proxyConfiguration gets deleted once we deploy a new task revision.
Currently we are using envoy as a side-car container and need to have the proxyConfiguration in place in order to be able to integrate the service into the AWS-Mesh.

cheers,
Aven

@mauritz-lovgren
Copy link

Yes, and the "name": "ecs.capability.aws-appmesh" is removed from requiresAttributes section in the resulting task definition as well.

@forevermatt
Copy link
Contributor

forevermatt commented Aug 18, 2023

heyja,

We are using this script and noticed, that the proxyConfiguration gets deleted once we deploy a new task revision. Currently we are using envoy as a side-car container and need to have the proxyConfiguration in place in order to be able to integrate the service into the AWS-Mesh.

cheers, Aven

Hi @avendretter. It looks like proxyConfiguration may simply need to be added to this line in ecs-deploy (based on the AWS docs). Can you test that to confirm whether it fixes the issue for you?


Edit: Used more appropriate AWS docs URL for ECS task definition attributes.

@forevermatt
Copy link
Contributor

Yes, and the "name": "ecs.capability.aws-appmesh" is removed from requiresAttributes section in the resulting task definition as well.

@mauritz-lovgren That sounds like it's probably a different issue. Would you mind submitting a new GitHub issue (and/or pull request) about that, to help us avoid losing track of your request when this issue is resolved?

@mauritz-lovgren
Copy link

@forevermatt :
I see now that the ecs.capability.aws-appmesh value is automatically set by AWS
when the proxyConfiguration section is added using the --proxy-configuration <json> option when registering the updated task def.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants