Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "angband" with "sil" or "sil-q" as appropriate #109

Open
rickhull opened this issue Jul 24, 2023 · 1 comment
Open

Replace "angband" with "sil" or "sil-q" as appropriate #109

rickhull opened this issue Jul 24, 2023 · 1 comment

Comments

@rickhull
Copy link

I have been playing sil off and on for just a couple years, more off than on. My understanding is that it's somewhat of a fork of angband, and so descends from the angband source code. At this point, I believe the games have diverged so significantly, that it might be useful to "cut ties" in some sense.

For example, rename src/angband.h to src/sil.h

Of course, this will have wide range of ripple effects. I am (tentatively) willing to put some effort into this, as far as creating a PR or long-lived branch. I can understand that this can hamper some things, like historical source comparisons, or trying to apply patches from pre-rename to post-rename.

Anyway, just thought I would throw it out there and see what you think.

[rwh@nixos:~/git/sil-q/msvc2022]$ git grep -i angband
sil-q.vcxproj:    <ClInclude Include="..\src\angband.h" />
sil-q.vcxproj.filters:    <ClInclude Include="..\src\angband.h">


[rwh@nixos:~/git/sil-q/Sil.xcodeproj]$ git grep -i angband
half.mode1:             <string>/Users/half/Dev/Angband/Sil/Sil.xcodeproj</string>
half.pbxuser:           path = /Users/half/Dev/Angband/Sil/Sil.app;
project.pbxproj:                076939FF276F9BC400BD6EBD /* angband.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = angband.h; path = src/angband.h; sourceTree = "<group>"; };
project.pbxproj:                                076939FF276F9BC400BD6EBD /* angband.h */,
Binary file project.xcworkspace/xcuserdata/half.xcuserdatad/UserInterfaceState.xcuserstate matches


[rwh@nixos:~/git/sil-q/lib]$ git grep -i angband | wc -l
70


[rwh@nixos:~/git/sil-q/src]$ git grep -i angband | wc -l
1517

Many of these references do not need to be changed under this proposal, as they are not remnants from the prior project but rather references to Angband itself, as a separate project.

@sil-quirk
Copy link
Owner

Sorry for the slow reply.

I have no real objections to this but it's a bit low on my priority list - time for Sil-Q has been hard to find for a while. If you want to put in a PR doing this I'll be happy enough to let it through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants