From 2ab18d72be5eee09cb062794017669d146cc0ef7 Mon Sep 17 00:00:00 2001 From: Miki Date: Fri, 20 Jan 2023 11:17:43 -0800 Subject: [PATCH] Fix detection of Chrome's version on Darwin (#3296) Signed-off-by: Miki Signed-off-by: Miki Signed-off-by: David Sinclair --- CHANGELOG.md | 1 + scripts/upgrade_chromedriver.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 73443bf45879..cc86738d0aa6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -102,6 +102,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Add automatic selection of the appropriate version of chrome driver to run functional tests ([#2990](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2990)) - Add recording of functional test artifacts if they fail ([#3190](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3190)) - Improve yarn's performance in workflows by caching yarn's cache folder ([#3194](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3194)) +- Fix detection of Chrome's version on Darwin during CI ([#3296](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3296)) ### 📝 Documentation diff --git a/scripts/upgrade_chromedriver.js b/scripts/upgrade_chromedriver.js index bb5200c30eec..3aa896fd1fa9 100644 --- a/scripts/upgrade_chromedriver.js +++ b/scripts/upgrade_chromedriver.js @@ -31,7 +31,7 @@ switch (process.platform) { case 'darwin': versionCheckCommands.push( - '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome --version' + '/Applications/Google\\ Chrome.app/Contents/MacOS/Google\\ Chrome --version' ); break;