protos: drop EXPERIMENTAL_ prefix #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
| // | ||
| // These keys and signatures may be used by private Sigstore | ||
| // deployments, but are not currently supported by the public | ||
| // good instance. |
There was a problem hiding this comment.
Do you think a comment along the lines of "here be dragons" would be good? This would cover some of the original motivation of the experimental prefix, that when using these, you should understand the cryptographic and performance consequences.
There was a problem hiding this comment.
Good idea! I'll add some additional warning language here.
Signed-off-by: William Woodruff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than mark these with
EXPERIMENTAL_(which would force a breaking change later), this keeps the LMS and LM-OTS variant names as we expect, but with a comment emphasizing that they aren't currently supported by the PGI.