Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation support when uploading blobs #2149

Open
cldmnky opened this issue Aug 11, 2022 · 2 comments
Open

Annotation support when uploading blobs #2149

cldmnky opened this issue Aug 11, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@cldmnky
Copy link
Contributor

cldmnky commented Aug 11, 2022

Annotations for blobs

We are using cosign to upload (and sign) release artifacts as blobs. We currently use something like:

cosign upload blob -f ./release/linux/myapp:linux/amd64 -f ./release/darwin/myapp:darwin/amd64 -f ./release/windows/myapp.exe:windows/amd64 private-registry.tld/foo/myapp/myapp:{{ .releaseVersion }}

It would be useful to be able to add (common) annotations to the descriptor(s) for the manifests to store some more information:

cosign upload blob -a date=xxxx -a name="a name" -f ./release/linux/myapp:linux/amd64 -f ./release/darwin/myapp:darwin/amd64 -f ./release/windows/myapp.exe:windows/amd64 private-registry.tld/foo/myapp/myapp:{{ .releaseVersion }}

This way we can in our custom code get a bit more metadata on the releases we have stored in the registry.

I'll be happy to prepare a PR if it makes sense!

@cldmnky cldmnky added the enhancement New feature or request label Aug 11, 2022
@dlorenc
Copy link
Member

dlorenc commented Aug 20, 2022

Maybe a different flag to make sure it's clear these are unprotected (not signed)?

@cldmnky
Copy link
Contributor Author

cldmnky commented Aug 21, 2022

Good point, I'll open a PR so we can figure out the flag name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants