Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for the different implementations vary #9

Closed
hagenw opened this issue Aug 29, 2019 · 3 comments
Closed

Tests for the different implementations vary #9

hagenw opened this issue Aug 29, 2019 · 3 comments

Comments

@hagenw
Copy link

hagenw commented Aug 29, 2019

The implementation of open-unmix-pytorch contains a reasonable amount of nice tests.

The same cannot be stated for open-unmix-nnabla which only contains a test for stft, and open-unmix-tensorflow, which does not contain any code/tests (see also #2 (comment)).

In my opinion this is fine if the structure of the paper would change with a focus on open-unmix-pytorch and mentioning the other packages only as additions. Otherwise I would expect a similar amount of tests in all three packages.

@faroit
Copy link
Member

faroit commented Aug 29, 2019

The same cannot be stated for open-unmix-nnabla which only contains a test for stft

For now, we cannot test the nnabla model on travis as the framework requires cudnn to run the LSTM layer.

In my opinion this is fine if the structure of the paper would change with a focus on open-unmix-pytorch and mentioning the other packages only as additions.

See #2

@faroit
Copy link
Member

faroit commented Aug 30, 2019

@hagenw SInce a decision was made in #2, this can be closed, right?

@hagenw
Copy link
Author

hagenw commented Sep 1, 2019

Yes, this is solved by #2.

@hagenw hagenw closed this as completed Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants