You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In my opinion this is fine if the structure of the paper would change with a focus on open-unmix-pytorch and mentioning the other packages only as additions. Otherwise I would expect a similar amount of tests in all three packages.
The text was updated successfully, but these errors were encountered:
The same cannot be stated for open-unmix-nnabla which only contains a test for stft
For now, we cannot test the nnabla model on travis as the framework requires cudnn to run the LSTM layer.
In my opinion this is fine if the structure of the paper would change with a focus on open-unmix-pytorch and mentioning the other packages only as additions.
The implementation of open-unmix-pytorch contains a reasonable amount of nice tests.
The same cannot be stated for open-unmix-nnabla which only contains a test for
stft
, and open-unmix-tensorflow, which does not contain any code/tests (see also #2 (comment)).In my opinion this is fine if the structure of the paper would change with a focus on open-unmix-pytorch and mentioning the other packages only as additions. Otherwise I would expect a similar amount of tests in all three packages.
The text was updated successfully, but these errors were encountered: