Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel in-flight RPC requests #4884

Closed
realbigsean opened this issue Oct 26, 2023 · 1 comment
Closed

Cancel in-flight RPC requests #4884

realbigsean opened this issue Oct 26, 2023 · 1 comment
Labels

Comments

@realbigsean
Copy link
Member

Description

Deneb introduces delayed-lookup logic, where we listen on gossip for a set period of time before triggering an RPC request. We're observing quite frequently that blocks/blobs arrive on gossip eventually and our RPC requests only serve to waste download. I think it'd be very beneficial to cancel in-flight RPC requests.

from @AgeManning

It would be pretty easy to cancel a request because we open a stream for each request. We can just drop the stream and it will cancel.

I can make a public function you can use to cancel requests if its useful

@realbigsean
Copy link
Member Author

No longer necessary due to #4992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant