Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard "liveness" endpoint in the VC #4522

Closed
paulhauner opened this issue Jul 20, 2023 · 2 comments
Closed

Use standard "liveness" endpoint in the VC #4522

paulhauner opened this issue Jul 20, 2023 · 2 comments
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! v4.6.0 ETA Q1 2024

Comments

@paulhauner
Copy link
Member

Description

We have two implementations of "liveness" detection in the BN API:

  1. lighthouse/liveness
  2. /eth/v1/validator/liveness/{epoch} (implemented in [Merged by Bors] - Implement liveness BeaconAPI #4343)

I think we should switch the VC to use (2) rather than (1). However, we should heed this comment:

Deciding how to handle it in the VC is slightly more complicated. We could switch to the standard endpoint as soon as it's available, but this would break compatibility with older versions of the Lighthouse BN. Alternatively we could wait a release or two before switching over the VC. I think I prefer switching immediately, as most users will update VC+BN together anyway.

I'm open to either strategy. If we get to implementing it in the VC before #4343 is released, then all is good. Otherwise, we're also fine.

@paulhauner paulhauner added v4.4.1 ETA August 2023 low-hanging-fruit Easy to resolve, get it before someone else does! labels Jul 20, 2023
@Gua00va
Copy link
Contributor

Gua00va commented Jul 21, 2023

I would like to work on this!

@paulhauner paulhauner added v4.5.0 ETA Q4 2023 and removed v4.4.1 ETA August 2023 labels Aug 24, 2023
@paulhauner paulhauner added v4.6.0 ETA Q1 2024 and removed v4.5.0 ETA Q4 2023 labels Sep 20, 2023
@jimmygchen
Copy link
Member

Completed in #4853 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! v4.6.0 ETA Q1 2024
Projects
None yet
Development

No branches or pull requests

3 participants