This repository has been archived by the owner on Feb 14, 2025. It is now read-only.
Keep simple walruses #533
Merged
Keep simple walruses #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjs-intel
force-pushed
the
pixeebot/drip-2024-02-20-pixee-python/use-walrus-if
branch
from
fa8cb21 to
4cde3bd
Compare
dwanderson-intel
approved these changes
Feb 26, 2024
tjs-intel
deleted the
pixeebot/drip-2024-02-20-pixee-python/use-walrus-if
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally #518
I think the walrus makes sense in a guard condition, ie.
I find additional logic after assignment creates too much complexity for a single expression.