Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't work for Next 15/React 19? #764

Open
ohitsdoh opened this issue Nov 27, 2024 · 5 comments
Open

doesn't work for Next 15/React 19? #764

ohitsdoh opened this issue Nov 27, 2024 · 5 comments

Comments

@ohitsdoh
Copy link

ohitsdoh commented Nov 27, 2024

Steps to reproduce:

  1. Upgrade to Next 15

Expected behaviour:
It to render

Observed behaviour:
Getting the following error:

image

@apeiniger
Copy link

Having the same issue with the react 19 production release

@zapbulon
Copy link

Hi, I also experienced the same thing and as it seems this library is silently disontinued I took the initiative to fix it for myself.

Currently you can check the code here (https://github.com/moxylabs/react-mentions/tree/v4.6.0) and use it like this in package.json
"react-mentions": "github:moxylabs/react-mentions#v4.6.0"

You can give it a try and let me know if it's fixed for you. Works in my use case but I can't guarantee it's fixed for all

If someone needs any feature in the other pull requests here merged I can do that in the repo above. If someone wants to convert it to TS or rewrite the class components to functonal components ... let's do this. I'm kinda ready to adopt it as it's easier for me than to switch to another lib

@isaacrmoreno
Copy link

@zapbulon This worked for my team. We just implemented this library a few weeks ago, so much appreciated!!

@apeiniger
Copy link

@zapbulon Thanks, that works, nice 👍

Only thing is I'm still getting errors when checking for typescript errors:

CleanShot 2024-12-14 at 12 43 10@2x

Are you still seeing the errors there?

@zapbulon
Copy link

@zapbulon Thanks, that works, nice 👍

Only thing is I'm still getting errors when checking for typescript errors:

CleanShot 2024-12-14 at 12 43 10@2x

Are you still seeing the errors there?

Unfortunately I have no idea what ReactPortal is and my best guess is it's something custom to yopur project? I'm not sure why it requires children prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants