From 8be85b9be243c94596226312cef8e953eca52864 Mon Sep 17 00:00:00 2001 From: Antoine Toulme Date: Tue, 22 Oct 2024 10:02:47 -0700 Subject: [PATCH] Deprecate collectd/mysql monitor (#5538) --- CHANGELOG.md | 1 + .../signalfx-agent/pkg/monitors/collectd/mysql/metadata.yaml | 2 ++ internal/signalfx-agent/pkg/monitors/collectd/mysql/mysql.go | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 754d73e1ff..d460b325b2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ - (Splunk) Deprecate windowslegacy monitor ([#5518](https://github.com/signalfx/splunk-otel-collector/pull/5518)) - (Splunk) Deprecate statsd monitor. Use the [statsd receiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/statsdreceiver) instead. ([#5513](https://github.com/signalfx/splunk-otel-collector/pull/5513)) - (Splunk) Deprecate the collectd/consul monitor. Please use the statsd or prometheus receiver instead. See https://developer.hashicorp.com/consul/docs/agent/monitor/telemetry for more information. ([#5521](https://github.com/signalfx/splunk-otel-collector/pull/5521)) +- (Splunk) Deprecate collectd/mysql monitor. Use the [mysql receiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/mysqlreceiver) instead. ([#5538](https://github.com/signalfx/splunk-otel-collector/pull/5538)) - (Splunk) Deprecate the collectd/nginx monitor. Please use the [nginx receiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/nginxreceiver/) instead. ([#5537](https://github.com/signalfx/splunk-otel-collector/pull/5537)) - (Splunk) Deprecate the collectd/chrony monitor. Please use the [chronyreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/chronyreceiver) instead. ([#5536](https://github.com/signalfx/splunk-otel-collector/pull/5536)) diff --git a/internal/signalfx-agent/pkg/monitors/collectd/mysql/metadata.yaml b/internal/signalfx-agent/pkg/monitors/collectd/mysql/metadata.yaml index 3e1c11199d..578e1eb711 100644 --- a/internal/signalfx-agent/pkg/monitors/collectd/mysql/metadata.yaml +++ b/internal/signalfx-agent/pkg/monitors/collectd/mysql/metadata.yaml @@ -1,6 +1,8 @@ monitors: - dimensions: doc: | + **The MySQL monitor is deprecated. Please use the mysqlreceiver instead.** + Monitors a MySQL database server using collectd's [MySQL plugin](https://collectd.org/wiki/index.php/Plugin:MySQL). It supports MySQL versions 5.x or later. diff --git a/internal/signalfx-agent/pkg/monitors/collectd/mysql/mysql.go b/internal/signalfx-agent/pkg/monitors/collectd/mysql/mysql.go index 6d59552508..18a5dbb07e 100644 --- a/internal/signalfx-agent/pkg/monitors/collectd/mysql/mysql.go +++ b/internal/signalfx-agent/pkg/monitors/collectd/mysql/mysql.go @@ -70,5 +70,5 @@ type Monitor struct { // Configure configures and runs the plugin in collectd func (am *Monitor) Configure(conf *Config) error { - return am.SetConfigurationAndRun(conf) + return am.SetConfigurationAndRun(conf, collectd.WithDeprecationWarningLog("mysqlreceiver")) }