Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we use ThreadRng instead of OsRng? #11

Closed
jack-signal opened this issue Oct 16, 2020 · 1 comment
Closed

Can we use ThreadRng instead of OsRng? #11

jack-signal opened this issue Oct 16, 2020 · 1 comment

Comments

@jack-signal
Copy link
Contributor

We still want to have the RNG be passed as an argument as that will allow us to provide a mock RNG (eg ChaCha with a fixed key) in order to perform known answer tests. But we can possibly switch from OsRng to ThreadRng to reduce some overhead.

Ideally this choice is encapsulated into a single function or type declaration somewhere.
@jack-signal
Copy link
Contributor Author

Dup of #6

jrose-signal added a commit that referenced this issue Oct 19, 2020
@jrose-signal
Merge pull request #11 from signalapp/jrose/idiomatic-swift
d821954 
Many small changes for more idiomatic Swift
@expiringplatform expiringplatform mentioned this issue Feb 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jack-signal