Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys that have been assigned Shift in X11 produce the original character #6813

Closed
2 tasks done
hadabascus opened this issue Mar 7, 2024 · 4 comments
Closed
2 tasks done
Labels

Comments

@hadabascus
Copy link

hadabascus commented Mar 7, 2024

Using a supported version?

  • I have searched searched open and closed issues for duplicates.
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

Today's Signal 7.2.0-beta.1 update introduced an input bug on GNU+Linux running an X11 based window manager. Pressing a key in a Signal chat produces the original character corresponding to the key, regardless of whether the key is set to be Shift in X11 configuration. This makes typing messages very uncomfortable.

This does not happen in any other program and did not happen prior to Signal 7.2.0-beta.1. Restarting Signal or rebooting the system does not help. Modifiers other than Shift_L and Shift_R are not affected.

Steps to reproduce

  1. Use an X11 based window manager in GNU+Linux
  2. Change the current layout in the layout file in /usr/share/X11/xkb/symbols/ by commenting out (by inserting //) the line starting with key <AD01>. Insert the line
key <AD01> { [ Shift_L, Shift_L, Shift_L, Shift_L ] };

You may replace the Q key <AD01> with any other key and you may replace Shift_L with Shift_R.
3. Reboot (or log out and log in)
4. Open any chat in Signal
5. Hold the Q key and press the W key

Expected result

The character W appears in your Signal chat.

Actual result

The characters QW appear in your Signal chat.

Screenshots

No response

Signal version

7.2.0-beta.1

Operating system

Linux 6.1.0-18-amd64 SMP PREEMPT_DYNAMIC Debian 6.1.76-1 Xfce 4.18

Version of Signal on your phone

No response

Link to debug log

No response

@scottnonnenberg-signal
Copy link
Contributor

@hadabascus Can you try Chrome or Chromium, to see if that same behavior reproduces there?

@hadabascus
Copy link
Author

@scottnonnenberg-signal This does not happen in Chromium 122.0.6261.111

@ayumi-signal
Copy link
Contributor

It appears like this is an upstream bug in electron. Based on electron fiddle testing, it seems like it was introduced in 29.0.0 and fixed in 29.0.1. We'll look into upgrading our dependency version.

@hadabascus
Copy link
Author

This is now fixed in Signal 7.2.0-beta.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants