Show errors to user for incoming invalid messages

[RobertZenz]

Bug Description

The messages I'm sending through a mobile client are no longer showing up in the desktop app. This used to work with 1.33.1 and since the update to 1.33.4 they are no longer showing up.

This seems to be the relevant section from the debug log:

ERROR 2020-05-11T16:54:49.570Z queueEnvelope error handling envelope +[REDACTED]384.1 1589201034069 (47e5bcd64eab40028d5c7d831f8136d4) : Error: Missing timestamp on dataMessage or envelope
    at MessageReceiver.processDecrypted (file://[REDACTED]/app.asar/js/libtextsecure.js:39721:13)
    at file://[REDACTED]/app.asar/js/libtextsecure.js:39215:12

Regarding the client, no, it's not the official app, it's a third-party app which is most likely out of date, but currently I do not have the means nor the time to change anything about that.

The relevant file and line seems to be this one, as far as I can tell. From looking a little at that code, I'm not sure whether that is a recoverable situation, but currently it seems that messages which are "malformed" like that are simply being dropped, without any notification to the user whatsoever and without any way to actually know why. Maybe these checks could be moved higher-up towards the GUI so that the messages are still being displayed but with warnings.

[scottnonnenberg-signal]

Essentially, you'd like us to surface better errors for invalid incoming messages. I'm going to mark this a feature request.

[RobertZenz]

Essentially, yes. I'd also like to actually see these messages despite errors, though, but I can see that this is quite a curios corner-case which I'm having.

[scottnonnenberg-signal]

Yep, for now I'd recommend that you follow up with that third-party app. It is absolutely sending invalid messages.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.