Feature Request: Graceful handling of corrupt database

[Garoth]

Bug Description

When the sqlite database becomes corrupt, Signal Desktop enters into a really bad unrecoverable state, where there is no messaging to the user, and reinstalling doesn't help.

It hangs while loading, saying either "Optimizing Application" or "Optimizing Messages"

More info: #2972

Steps to Reproduce

Reproduction is unreliable. Seems that sqlite database can become corrupt when the computer crashes, or signal is force-quit. Perhaps you can manually corrupt the database file to trigger the effect

Expected Result:

Signal Desktop can recover from a corrupted database. It cannot currently. Stuff that you'd think might help but doesn't:

• Reinstalling Signal (doesn't help)
• Using red button in preferences to "Clear Data" (doesn't delete corrupt database)

Signal should do one of the following:

• Make Clear Data delete the actual database file
• Make a clear message when there's a major crash like corrupt database
• Optionally make a dialog that will recover from this state for you

Platform Info

Signal Version: v1.21.2

Operating System:

MacOS 10.14.2 Mojave

Link to Debug Log

See logs here: #2972 (comment)

[deutrino]

Just as a data point, I experience this every couple of months at this point as a heavy Signal user.

'apt purge' plus nuking .config/Signal plus 'apt install' is becoming far too familiar.

[scottnonnenberg-signal]

This was added in v1.22.

[6lancmange]

@scottnonnenberg I believe this is what happened to me, and I had at least 1.22. I deleted Signal and I can't even reinstall it now, because Signal made by Open Whisper Systems disappeared from the Ubuntu Software "shop", there's only Signal Desktop made by Snapcrafters. Can I trust it? That's one question, but also, are there still Signal files on this laptop? I believe there must be, since as OP said, unlinking and reinstalling doesn't help, and "clear data" doesn't do anything – this is exactly what I had. Where can I find all the files to definitively remove Signal and how to install it? I'm using Ubuntu 18.04.2 LTS.

edit: K, I think I managed to fix it, and now I have 1.24.1 – and I'm pretty sure I had the same version when it got messed up.