Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating signal (chrome) to signal (standalone) - export/import both fail #1660

Closed
1 task done
tx3eh8IUD1 opened this issue Nov 1, 2017 · 7 comments
Closed
1 task done

Comments

@tx3eh8IUD1
Copy link

tx3eh8IUD1 commented Nov 1, 2017

  • I have searched open and closed issues for duplicates

Bug description

The signal app (Chrome) gives me the following error when trying to export my data to a folder:
"Unfortunately, something went wrong during the export. First, double-check your target empty directory for write access and enough space. Then, please submit a debug log so we can help you get migrated!"

I have both write-access and enough space. About 1.2gb of data is written. Should I worry about the error?

Steps to reproduce

  • bug is reproducible, even after starting the computer (or app) again

Actual result: I get the error (see above), even though signal does export (some?) data
Expected result: I would love to get some sort of "success!" message, so that I can migrate to signal standalone

Screenshots

I don't think screens are necessary. The error is pasted above, I uploaded everything here:
https://gist.github.com/ea641dba7fa642c07652e28ca301b26a

Platform info

Operating System: Win 10, 64bit, Version 10.0.16299
Browser: Chrome Version 61.0.3163.100 (Official Build) (64-bit) or
Version 62.0.3202.75 (Official Build) (64-bit)
Signal version: 0.44.1

Link to debug log

https://gist.github.com/ea641dba7fa642c07652e28ca301b26a

What happens on import to Signal standalone (Electron):

"Unfortunately, something went wrong during the import.
First, double-check your target directory. It should start with 'Signal Export.'

Next, try with a new export of your data from the Chrome App.

If that still fails, please submit a debug log so we can help you get migrated!"

also reproducible.

I cannot post the debug from signal standalone, as there are CLEAR TEXT NAMES in there. How come this is not properly redacted??? :(

Edit:
Possibly similar bugs?
#1647
#1616

@scottnonnenberg
Copy link
Contributor

scottnonnenberg commented Nov 1, 2017

Yes, it's likely that you'll receive an error when trying to import that into the Electron, because it will have a missing attachment. You could try to delete that entire conversation, but then you'd miss all the conversations that would have come after that.

@tx3eh8IUD1
Copy link
Author

tx3eh8IUD1 commented Nov 1, 2017

Oh - if that's the only problem, then I am totally OK with that. Thanks for the info. I had troubles reading the debug log as a laymen. I don't care about the occasional attachment to get lost, as long as the messages are kept.

Edit:
@scottnonnenberg , thanks for the info. Sadly, you were right - Electron fails on import.

@scottnonnenberg
Copy link
Contributor

Can you talk a little bit more about what you did to find 'clear text names?' in the log? Did you open the devtools, or did you go to the debug log with View -> Debug Log?

@tx3eh8IUD1
Copy link
Author

tx3eh8IUD1 commented Nov 2, 2017

For one thing, my name is my "login name", so that is one issue that signal logs likely cannot work around.
E.g. "C:\Users\REAL NAME\"
Edited to add: no such problems arise when looking at the signal chrome log (see above) - I guess it is possible to redact the important bits. Sadly, this does not happen properly in Signal (standalone).

However, there is more - group names are exported in plain text, and they happen to include real names as well. I think these names appear in names of group chats, which appear in plain text in the debug log.

When trying to import the signal chrome data, I get an error. If I then click on View -> Debug Log, I get lots of lines of log, some looking like this:
INFO 2017-11-01T21:42:53.130Z Error importing: Error: ENOENT: no such file or directory, open 'C:\Users\REAL NAME (MYSELF)\Handy\Signal\Signal Export 2017 Nov 1 at 10.28.45 pm\1509554487924 (REAL NAME LAST, FIRST (Part of Group name???) ____y_kGzhC_J__d)\1502721134634\5436375466824584358.jpeg'

@tx3eh8IUD1 tx3eh8IUD1 changed the title Migrating signal (chrome) to signal (standalone) - should I worry about the errors? Migrating signal (chrome) to signal (standalone) - export/import both fail Nov 2, 2017
@scottnonnenberg
Copy link
Contributor

@tx3eh8IUD1 Yep. To make things easier for you we allow real names to go to disk. But then our error messages are un-redacted if they include a path.

@scottnonnenberg
Copy link
Contributor

Can you check export/import with the latest versions of Chrome (v0.44.9) and Electron (v1.0.36)? A lot of fixes have been made.

@tx3eh8IUD1
Copy link
Author

I tried again. Sorry that it took me so long to get back to you.

Chrome: Version 62.0.3202.89 (Official Build) (64-bit)
Signal in Chrome: Version: 0.44.11 (note: this is a higher version number than you gave me?)
Signal Win: Signal-win-1.0.37 (note: this is a higher version number than you gave me?)

No error on export! This looks like success:
image

Also success on import:
image

Very cool - thank you for all the improvements.
From my side, all important things are now fixed. Everything looks and feels the same (nevermind some pics that were not on my phone anymore anyways...).
Great work! Keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants