Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invited Member is always shown as Unknown in Group Update Messages #13903

Open
3 tasks done
Sagar0-0 opened this issue Jan 11, 2025 · 0 comments
Open
3 tasks done

Invited Member is always shown as Unknown in Group Update Messages #13903

Sagar0-0 opened this issue Jan 11, 2025 · 0 comments

Comments

@Sagar0-0
Copy link
Contributor

Guidelines

  • I have searched searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

  1. Invite a member in a group
  2. It it's a pending member, we'll see a Group Update message ass You invited Unknown to the group.
  3. It should show the Contact name/Username of the invited person.

I have explored every aspect of the code related to this issue, but couldn't find the actual cause. Although, I have logged and verified some places of the code that works as expected. Here, I will add some start points for direct jumps in the code.

  1. updateDescription function line 1482 in `GroupV2UpdateMessageProducer, responsible for getting the Recipient from the sent serviceId1Bytes.

Some logs from this flow:
serviceId1Bytes as byte array = 104, -79, -20, -66, -82, -46, 74, -105, -80, -79, -33, 124, 31, 67, 70, -123
serviceId after ACI.parseOrUnknow(this is resilient) = 00000...
recipientId = -1

After this, I tried to find the problem at the producer site, where we are actually adding the pendingMembers.

  1. In GroupsV2Operations class we have invitee function line 424, responsible for creating PendingMember object for a group(new/existing).

  2. ConversationListDataSource line 93, record.getMessageExtras() is the actual class that holds these inviteeServiceId internally. Let me know if I am on the right track or if I m missing something.

Screenshots

photo_6057404072648099298_y

Device

Realme GT NEO 3T

Android version

14

Signal version

7.29.2

Link to debug log

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant